use longhand rules for spacing to avoid radium warnings#252
Merged
Conversation
Brantron
force-pushed
the
brantron/margins-padding
branch
from
9d3dc59 to
da0efc4
Compare
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 79.88% 79.92% +0.03%
==========================================
Files 57 57
Lines 1064 1066 +2
Branches 243 243
==========================================
+ Hits 850 852 +2
Misses 155 155
Partials 59 59 |
dcocchia
reviewed
Sep 19, 2018
| const createYRules = (type, value) => ({ | ||
| [`${type}Top`]: value, | ||
| [`${type}Bottom`]: value | ||
| }) |
Member
There was a problem hiding this comment.
Should we memoize these? It's possible they'll be called very frequently if someone is using them in a render()
Collaborator
There was a problem hiding this comment.
I don't think we need to memoize these because it looks like they are used internally only to generate the spacing object. That simple spacing object is then what could be called many times by the user.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246