Skip to content

Can haz expanded border radius properties?#269

Merged
spencerschack merged 1 commit intomasterfrom
spencerschack/expand-border-radius-properties
Oct 17, 2018
Merged

Can haz expanded border radius properties?#269
spencerschack merged 1 commit intomasterfrom
spencerschack/expand-border-radius-properties

Conversation

@spencerschack
Copy link
Copy Markdown
Contributor

Expand the borderRadius style property of Button into borderRadiusTopLeft etc. so users can override these properties to make things like segmented controls.

Copy link
Copy Markdown
Member

@dcocchia dcocchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcocchia
Copy link
Copy Markdown
Member

I'm wondering more if we should add a lint rule to require expanded css properties 🤔

Copy link
Copy Markdown
Contributor

@loganmurdock loganmurdock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@spencerschack
Copy link
Copy Markdown
Contributor Author

@dcocchia +1 to that

@spencerschack spencerschack merged commit 021be12 into master Oct 17, 2018
@spencerschack spencerschack deleted the spencerschack/expand-border-radius-properties branch October 17, 2018 21:22
@mmarcuccio
Copy link
Copy Markdown
Collaborator

I'm wondering more if we should add a lint rule to require expanded css properties 🤔

Maybe we could do this for all CSS properties using this: https://www.npmjs.com/package/css-shorthand-properties

@spencerschack spencerschack mentioned this pull request Oct 17, 2018
@spencerschack
Copy link
Copy Markdown
Contributor Author

Oh man I would hate to define borders then:

// Using 'border' with recursion returns an array of arrays
cssShorthandProps.expand('border', true);
/*
[
  ['border-top-width', 'border-right-width', 'border-bottom-width', 'border-left-width'],
  ['border-top-style', 'border-right-style', 'border-bottom-style', 'border-left-style'],
  ['border-top-color', 'border-right-color', 'border-bottom-color', 'border-left-color']
]
*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants