Create JsonResponse and add response status code assertions#45
Merged
robocoder merged 2 commits intoinstaclick:masterfrom Dec 20, 2013
Merged
Create JsonResponse and add response status code assertions#45robocoder merged 2 commits intoinstaclick:masterfrom
robocoder merged 2 commits intoinstaclick:masterfrom
Conversation
Member
|
phpunit convention is that every assert method can take an optional message parameter. |
…just for location
robocoder
added a commit
that referenced
this pull request
Dec 20, 2013
Create JsonResponse and add response status code assertions
Contributor
There was a problem hiding this comment.
Why no Response typehint on these helper assertions?
Contributor
Author
There was a problem hiding this comment.
A few reasons, but the main one is: If you look the JsonResponse class, it's actually a composition of a Response object and it would fail the type hint.
Contributor
There was a problem hiding this comment.
class JsonResponse extends ResponseThe type hint should not fail.
Contributor
Author
There was a problem hiding this comment.
JsonResponse is not inheriting Response it's a composition.
Contributor
There was a problem hiding this comment.
Are you talking about Symfony\Component\HttpFoundation\JsonResponse ?
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonResponse makes life easier for testing properties, expected use:
New assertions for checking response status code to avoid hard coding numbers everywhere.