Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@ChristopheSchmitz
Copy link
Contributor

A few things in this PR:

  • I think the cluster-id / instaclustr username / instaclustr password should not be in the bracket [ ]. Didn't work for me
  • I added a custom tag list to be set at the configuration level
  • Instead of creating one metric name per (public_ip, cassandra-metric) combination, I think we should report the metric using the cassandra-metric-name. Then we can slice with the extra tags that are now automatically created in the code, based on the rest api json we get.

@ChristopheSchmitz
Copy link
Contributor Author

Probably need to be tested from a mac

@slater-ben slater-ben merged commit bc6d6de into master May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants