Merged
Conversation
aryamohanan
reviewed
Oct 6, 2025
Contributor
aryamohanan
left a comment
aryamohanan
left a comment
There was a problem hiding this comment.
Let's wait for the currency jira card to be created
Contributor
|
It seems to me they dropped Node v18 without sharing that on the release notes. |
Contributor
|
We can just skip the Node v18 tests for pino v10. No need to run both v9 and v10 IMO. |
Contributor
agree 👍 |
aryamohanan
changed the title
kirrg001
approved these changes
Oct 7, 2025
Pino v10(latest) requires Node.js 20 or higher
kirrg001
force-pushed
the
currency-bot-major-pino-1000
branch
from
aa586b4 to
37620b1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://jsw.ibm.com/browse/INSTA-58047