refactor: simplified bull child process initialization #2008
Conversation
| } | ||
| } | ||
|
|
||
| // TODO: This is not used anymore. Investigate any usages. Potentially remove/deprecate in the next major release. |
There was a problem hiding this comment.
Added note to https://jsw.ibm.com/browse/INSTA-786
There was a problem hiding this comment.
Its super nice that we might be able to remove activateImmediately functionality
There was a problem hiding this comment.
It seems this configuration option isn’t documented, but we can look into it later. It’s really nice to discover such untouched or unknown parts of our codebase.
|
|
||
| // Activate immediately, otherwise we miss the first message event and the instana | ||
| // headers would not get removed from the message. | ||
| exports.activate(); |
There was a problem hiding this comment.
Instead of activating everything, we just activate what we need. The config even says it
activateBullProcessInstrumentation
| // this is not compatible. Our codebase does not support this. | ||
| const parentProcessAgentUuid = process.env.INSTANA_AGENT_UUID; | ||
| // CASE: This process is a forked child process of a bull worker. | ||
| const currentProcessIsBullChildProcess = process.env.INSTANA_IS_BULL_CHILD_PROCESS === 'true'; |
There was a problem hiding this comment.
Changed from INSTANA_AGENT_UUID to exact env INSTANA_IS_BULL_CHILD_PROCESS.
This env is not documented INSTANA_AGENT_UUID.
| // @ts-ignore - Type 'string' is not assignable to type 'undefined' | ||
| // Probably because exports.agentUuid is set to undefined and export values were not supposed to be changed | ||
| // TODO: This has no effect. Remove! See comment above. | ||
| agentOpts.agentUuid = parentProcessAgentUuid; |
There was a problem hiding this comment.
Finally getting rid of this dirty code. It was not working anyway
kirrg001
force-pushed
the
refactor-bull-env
branch
from
5d0c09c to
05fc7a4
Compare
See comments.
refs #2002