fix: resolved pino compatibility issues for v18 #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
changed the title
abhilash-sivan
approved these changes
Sep 18, 2025
Contributor
abhilash-sivan
left a comment
abhilash-sivan
left a comment
There was a problem hiding this comment.
We can reenable updates once we remove node v18 from support or the issue gets resolved
kirrg001
approved these changes
Sep 18, 2025
Contributor
kirrg001
left a comment
kirrg001
left a comment
There was a problem hiding this comment.
LGTM
We need a blocker JIRA issue to revert this change 👍
fix: resolved pino compatibility issues for v18
Contributor
Author
|
created card to revert the change https://jsw.ibm.com/browse/INSTA-55339 |
aryamohanan
changed the title
|
I am still facing the same issue even after you reverted the latest updates. |
Contributor
Author
|
@MukulWBD The actual issue has been reported here: pinojs/pino#2289. Please share your concern on that thread. |
aryamohanan
added a commit
that referenced
this pull request
Sep 22, 2025
This reverts commit a286f29.
aryamohanan
added a commit
that referenced
this pull request
Sep 22, 2025
This reverts commit a286f29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins
pinoto version 9.9.5 to avoid compatibility issues inv9.10.0.Issue:
The pipeline v18.18 ESM is failing due to the latest Pino update.
It throws
because tracingChannel() is not available in Node.js v18.18.
This method was added in the latest Pino release, pino#2281 and diagnostics_channel.tracingChannel was introduced in Node.js starting from v18.19 (see Node.js docs).
An issue has been created in the Pino repo regarding this incompatibility.