Fix trace context extraction in AWS Lambda #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion is invoked via ELB and API Gateway
andrewslotin
force-pushed
the
fix_lambda_trace_context_extraction
branch
from
3d17946 to
77b1f0c
Compare
pglombardo
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP headers are passed in the
headerssection of event payload when a Lambda function is invoked via ELB and API Gateway, while Python sensor's Lambda instrumentation passes the whole event to thetracer.extract(). As a result the tract context is not being picked up, forcing each Lambda invocation to start a new trace.In this PR
get_context()attempts to detect the event type and pass the appropriate object to the propagator.