Add synthetic calls support #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewslotin
force-pushed
the
add_support_for_x_instana_synthetic
branch
from
b483a65 to
a832cf9
Compare
added 4 commits
July 16, 2020 18:10
andrewslotin
force-pushed
the
add_support_for_x_instana_synthetic
branch
from
a832cf9 to
3f2bc2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark HTTP calls made with
X-Instana-Syntheticheader set to1as synthetic by sendingspan.sy: trueto the host agent for the instrumentation span.This branch is on top of #248 that addresses trace context extraction issue for Lambda.
@pglombardo, please note that
extractnow may return a span context without a trace ID if the synthetic call did not containX-Instana-{T,S}headers. I believe thetracer.start_spanchange should address it, but I'd appreciate if you could give it a thorough view.Closes #231