Serverless Span Filtering#872
Merged
Merged
Conversation
pvital
force-pushed
the
serverless_span_filtering
branch
4 times, most recently
from
fa40697 to
cf2c136
Compare
CagriYonca
requested changes
May 13, 2026
Contributor
CagriYonca
left a comment
CagriYonca
left a comment
There was a problem hiding this comment.
I left a few comments but overall new changes seem more structured than before. Great job
Introduce a new ServerlessAgent abstract base class to eliminate code duplication across serverless platforms and add support for the Span Filtering feature. This refactoring follows the Template Method pattern, allowing platform-specific customization through abstract methods while maintaining a single source of truth for the common serverless agent behavior. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Add and update agent tests to validate the new agent architecture: - 890 lines in test_base_agent.py for BaseAgent functionality - 447 lines in test_serverless_agent.py for ServerlessAgent base class - 217 lines in test_fargate_span_filtering.py for Fargate span filtering - Update test_host.py and test_eksfargate.py to align with refactored code Ensures all agent implementations maintain correct behavior after the serverless agent consolidation refactoring. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
serverless_span_filtering
branch
from
cf2c136 to
8ad6d39
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Span Filtering feature to the Serverless Agents. It consists of two commits that:
Introduce a new ServerlessAgent abstract base class to eliminate code duplication across serverless platforms and add support for the Span Filtering feature.
This refactoring follows the Template Method pattern, allowing platform-specific customization through abstract methods while maintaining a single source of truth for the common serverless agent behavior.
Add and update agent tests to validate the new agent architecture:
Ensures all agent implementations maintain correct behavior after the serverless agent consolidation refactoring.