feat(otlp-exporter): add error stack trace to base converter#515
Merged
Conversation
- Introduce SpanDataWithEvents wrapper to carry OTel span events without breaking the existing SpanData keyword_init constructor - Add build_error_events: emits exception event (with stacktrace) or error event when span.ec > 0 - Add convert_stack_trace: maps Instana stack frames (c/n/m) to OTel exception.stacktrace newline-separated string - Refactor convert_status → build_status(error_count, error_msg) to decouple status from implicit span state - Implement extract_error_message: searches span[:data][type][:error], truncates to 1024 chars per OTel recommendation - Fix span_name for custom (SDK) spans: read span[:data][:sdk][:name] instead of span[:n] - Extend base_converter_test with coverage for all new paths Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
base_converter.rbSpanDataWithEvents– wrapsSpanDatato carry OTelEventobjects viaForwardablebuild_error_events– emits"exception"(with stacktrace) or"error"event whenspan.ec > 0convert_stack_trace– maps Instana{c, n, m}stack frames to OTel newline-separated stringbuild_status– replacesconvert_status; accepts expliciterror_count/error_msgargsextract_error_message– readsspan[:data][type][:error], truncates to 1024 charsspan_name– fixed for SDK spans to readspan[:data][:sdk][:name]base_converter_test.rb– adds coverage for all new methods above