Fix/2173 only accept int numeric answers #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2173.
In Elixir,
Then, the methods
is_numeric_permissive&is_numericwere accepting float values and passed them through.While before it was continuing with the survey, now:
Note: is easy to round the integer part and get it: I moved forward accepting integers strictly, and returning
falseotherwise (and not the number rounded to an integer).Note 2: this was happening only in SMS mode (it couldn't happen in phone channels ─an error is thrown upon responses containing
#or*─, neither in the mobile web mode, where ─at least in the simulator─ the validation is performed well.