fix(dockerfile): avoid build hang at ARG statement #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 24.08% 24.08%
=======================================
Files 191 191
Lines 6723 6723
Branches 800 800
=======================================
Hits 1619 1619
Misses 5087 5087
Partials 17 17 ☔ View full report in Codecov by Sentry. |
heiruwu
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.8.0](v0.7.1...v0.8.0) (2024-04-25) ### Features * **deps:** upgrade ray version ([cc61b85](cc61b85)) * **ray:** adapt to native docker client instead of docker sdk ([#138](#138)) ([7d19ccb](7d19ccb)) * **ray:** add accelerator and custom resource support ([#118](#118)) ([f974f98](f974f98)) * **ray:** add llava 13b to predeploy list ([3fd5914](3fd5914)) * **ray:** add metadata and infer constructor for llm tasks ([#137](#137)) ([be122d1](be122d1)) * **ray:** generate sha256 as tag if not presented ([#120](#120)) ([6abb538](6abb538)) * **ray:** inject accelerator type at runtime ([#121](#121)) ([f78a2d0](f78a2d0)) * **ray:** support containerized model serving ([#116](#116)) ([ad0f250](ad0f250)) * **ray:** support custom accelerator type ([#134](#134)) ([ae6c139](ae6c139)) * **ray:** use env for resource and deprecate deploy/undeploy ([#124](#124)) ([a58bc50](a58bc50)) * **ray:** use tmp folder for image building ([#122](#122)) ([9512cec](9512cec)) ### Bug Fixes * **deps:** downgrade ray to avoid grpc servicer issue ([#128](#128)) ([9ead421](9ead421)) * **dockerfile:** avoid build hang at ARG statement ([#130](#130)) ([f02a27c](f02a27c)) * **ray:** fix etrypoint module not found ([#126](#126)) ([f1ed83d](f1ed83d)) * **ray:** fix missing default resource value ([#129](#129)) ([b2f564a](b2f564a)) * **ray:** fix multi-platform build stage ([6f358fd](6f358fd)) * **ray:** support target platform for image building ([#127](#127)) ([f4825fc](f4825fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
ARGstatement and change the statement order seems to solve it for now, need to keep an eye on it.This commit
ARGstatement orderresolves INS-4015