Skip to content

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Mar 27, 2024

Because

  • model.py not in the user root dir and will cause
File "/home/ray/anaconda3/lib/python3.11/site-packages/ray/_private/utils.py", line 1194, in import_attr
    return getattr(module, attr_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'model' has no attribute 'entrypoint'

This commit

  • move the model files back into user root
  • update scope of model file size calculation

@codecov
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 24.11%. Comparing base (6d2c44d) to head (dac75a9).

Files Patch % Lines
instill/helpers/utils.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   24.13%   24.11%   -0.03%     
==========================================
  Files         191      191              
  Lines        6708     6714       +6     
  Branches     1065     1067       +2     
==========================================
  Hits         1619     1619              
- Misses       5072     5078       +6     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit f1ed83d into main Mar 27, 2024
@heiruwu heiruwu deleted the fix-module-not-found branch March 27, 2024 09:06
heiruwu pushed a commit that referenced this pull request Apr 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.8.0](v0.7.1...v0.8.0)
(2024-04-25)


### Features

* **deps:** upgrade ray version
([cc61b85](cc61b85))
* **ray:** adapt to native docker client instead of docker sdk
([#138](#138))
([7d19ccb](7d19ccb))
* **ray:** add accelerator and custom resource support
([#118](#118))
([f974f98](f974f98))
* **ray:** add llava 13b to predeploy list
([3fd5914](3fd5914))
* **ray:** add metadata and infer constructor for llm tasks
([#137](#137))
([be122d1](be122d1))
* **ray:** generate sha256 as tag if not presented
([#120](#120))
([6abb538](6abb538))
* **ray:** inject accelerator type at runtime
([#121](#121))
([f78a2d0](f78a2d0))
* **ray:** support containerized model serving
([#116](#116))
([ad0f250](ad0f250))
* **ray:** support custom accelerator type
([#134](#134))
([ae6c139](ae6c139))
* **ray:** use env for resource and deprecate deploy/undeploy
([#124](#124))
([a58bc50](a58bc50))
* **ray:** use tmp folder for image building
([#122](#122))
([9512cec](9512cec))


### Bug Fixes

* **deps:** downgrade ray to avoid grpc servicer issue
([#128](#128))
([9ead421](9ead421))
* **dockerfile:** avoid build hang at ARG statement
([#130](#130))
([f02a27c](f02a27c))
* **ray:** fix etrypoint module not found
([#126](#126))
([f1ed83d](f1ed83d))
* **ray:** fix missing default resource value
([#129](#129))
([b2f564a](b2f564a))
* **ray:** fix multi-platform build stage
([6f358fd](6f358fd))
* **ray:** support target platform for image building
([#127](#127))
([f4825fc](f4825fc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 👋 Done

Development

Successfully merging this pull request may close these issues.

3 participants