Skip to content

fix(ray): support target platform for image building #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(ray): support target platform for image building #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion instill/helpers/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import argparse
import hashlib
import os
import platform
import shutil
import tempfile

Expand All @@ -14,14 +15,24 @@

if __name__ == "__main__":
Logger.i("[Instill Builder] Setup docker...")

if platform.machine() in ("i386", "AMD64", "x86_64"):
default_platform = "amd64"
else:
default_platform = platform.machine()
parser = argparse.ArgumentParser()
parser.add_argument(
"--no-cache",
help="build the image without cache",
action="store_true",
required=False,
)
parser.add_argument(
"--target-arch",
help="target platform architecture for the model image, default to host",
default=default_platform,
choices=["arm64", "amd64"],
required=False,
)

client = docker.from_env()
try:
Expand Down Expand Up @@ -66,6 +77,7 @@
rm=True,
pull=True,
nocache=args.no_cache,
platform=f"linux/{args.target_arch}",
tag=f"{repo}:{tag}",
buildargs={
"RAY_VERSION": ray_version,
Expand Down