Skip to content

feat(ray): support cuda version and fix user root permission #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

feat(ray): support cuda version and fix user root permission #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions instill/helpers/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ RUN for package in ${PACKAGES}; do \
done;

WORKDIR /home/ray
COPY --link --exclude=model.py . .
COPY model.py model.py
COPY --chown=ray:users --exclude=model.py . .
COPY --chown=ray:users model.py model.py
14 changes: 9 additions & 5 deletions instill/helpers/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def build_image():
"-t",
"--tag",
help="tag for the model image",
default="",
default=hashlib.sha256().hexdigest(),
required=False,
)
parser.add_argument(
Expand Down Expand Up @@ -64,13 +64,17 @@ def build_image():

build = config["build"]
repo = config["repo"]
tag = args.tag if args.tag != "" else hashlib.sha256().hexdigest()

python_version = build["python_version"].replace(".", "")
ray_version = ray.__version__
instill_version = instill.__version__

cuda_suffix = "" if not build["gpu"] else "-cu121"
if not build["gpu"]:
cuda_suffix = ""
elif "cuda_version" in build and not build["cuda_version"] is None:
cuda_suffix = f'-cu{build["cuda_version"].replace(".", "")}'
else:
cuda_suffix = "-gpu"

system_str = ""
if "system_packages" in build and not build["system_packages"] is None:
Expand Down Expand Up @@ -116,7 +120,7 @@ def build_image():
"--platform",
f"linux/{args.target_arch}",
"-t",
f"{repo}:{tag}",
f"{repo}:{args.tag}",
tmpdir,
"--load",
]
Expand All @@ -126,7 +130,7 @@ def build_image():
command,
check=True,
)
Logger.i(f"[Instill Builder] {repo}:{tag} built")
Logger.i(f"[Instill Builder] {repo}:{args.tag} built")
except subprocess.CalledProcessError:
Logger.e("[Instill Builder] Build failed")
except Exception as e:
Expand Down