Skip to content

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Jul 18, 2024

Because

  • Our protogen model module import name will collide with local model.py

This commit

  • avoid module name collision by temporarily remove cwd path from sys.path

@heiruwu heiruwu requested a review from joremysh as a code owner July 18, 2024 17:12
@heiruwu heiruwu merged commit 8345d17 into main Jul 18, 2024
@heiruwu heiruwu deleted the fix-import-collision branch July 18, 2024 17:13
heiruwu added a commit that referenced this pull request Aug 7, 2024
Because

- Our protogen `model` module import name will collide with local
`model.py`

This commit

- avoid module name collision by temporarily remove cwd path from
`sys.path`
heiruwu added a commit that referenced this pull request Sep 3, 2024
Because

- Our protogen `model` module import name will collide with local
`model.py`

This commit

- avoid module name collision by temporarily remove cwd path from
`sys.path`
heiruwu added a commit that referenced this pull request Sep 5, 2024
Because

- Our protogen `model` module import name will collide with local
`model.py`

This commit

- avoid module name collision by temporarily remove cwd path from
`sys.path`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 👋 Done

Development

Successfully merging this pull request may close these issues.

3 participants