Skip to content

fix(app): rename app_service to app #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix(app): rename app_service to app #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions instill/clients/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ def __init__(
"Instill Artifact is not serving, Artifact functionalities will not work"
)

self.app_service = AppClient(
self.app = AppClient(
api_token=api_token,
url=url,
secure=secure,
lookup_func=self._lookup_namespace_uid,
requester_id=requester_id,
async_enabled=async_enabled,
)
if not self.app_service.is_serving():
if not self.app.is_serving():
Logger.w("Instill App is not serving, App functionalities will not work")

def _lookup_namespace_uid(self, namespace_id: str):
Expand All @@ -96,14 +96,14 @@ def close(self):
self.pipeline.close()
self.model.close()
self.artifact.close()
self.app_service.close()
self.app.close()

async def async_close(self):
self.mgmt.async_close()
self.pipeline.async_close()
self.model.async_close()
self.artifact.async_close()
self.app_service.async_close()
self.app.async_close()

def get_mgmt(self) -> MgmtClient:
return self.mgmt
Expand All @@ -118,7 +118,7 @@ def get_model(self) -> ModelClient:
return self.model

def get_app(self) -> AppClient:
return self.app_service
return self.app


def init_core_client(
Expand Down
Loading