Skip to content

fix(ray): update high scale model config #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix(ray): update high scale model config #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions instill/helpers/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ class ImageToImageInput:
"PYTHONPATH": os.getcwd(),
},
}
DEFAULT_MAX_ONGOING_REQUESTS = 6
DEFAULT_MAX_QUEUED_REQUESTS = 100
DEFAULT_MAX_ONGOING_REQUESTS = 4
DEFAULT_MAX_QUEUED_REQUESTS = 1000

RAM_MINIMUM_RESERVE = 1 # GB
RAM_UPSCALE_FACTOR = 1.25
Expand Down
17 changes: 17 additions & 0 deletions instill/helpers/ray_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ def __init__(self, deployable: Deployment) -> None:
if is_high_scale_model is not None and is_high_scale_model.lower() == "true":
self._update_upscale_delay(120)
self._update_downscale_delay(600)
self._update_target_ongoing_requests(4)
self._update_max_concurrent_requests(6)

def _determine_vram_usage(self, model_path: str, total_vram: str):
warn(
Expand Down Expand Up @@ -189,6 +191,21 @@ def _update_max_replicas(self, num_replicas: int):

return self

def _update_target_ongoing_requests(self, target_ongoing_requests: int):
self._autoscaling_config["target_num_ongoing_requests_per_replica"] = (
target_ongoing_requests
)
self._autoscaling_config["target_ongoing_requests"] = target_ongoing_requests
self._deployment = self._deployment.options(
autoscaling_config=self._autoscaling_config
)

def _update_max_concurrent_requests(self, max_concurrent_requests: int):
self._deployment = self._deployment.options(
max_concurrent_queries=max_concurrent_requests,
max_ongoing_requests=max_concurrent_requests,
)

def _update_upscale_delay(self, upscale_delay_s: int):
self._autoscaling_config["upscale_delay_s"] = upscale_delay_s
self._deployment = self._deployment.options(
Expand Down