Skip to content

refactor(config)!: update config file path to avoid collision #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor(config)!: update config file path to avoid collision #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ $ python

### Config `Instill Core` or `Instill Cloud` instance

Before we can start using this SDK, you will need to create a config file under this path `${HOME}/.config/instill/config.yaml`, and within that path you will need to fill in some basic parameters for your desired host.[^1]
Before we can start using this SDK, you will need to create a config file under this path `${HOME}/.config/instill/sdk/python/config.yaml`, and within that path you will need to fill in some basic parameters for your desired host.[^1]

[^1]: You can obtain an `api_token`, by simply going to Settings > API Tokens page from the console, no matter it is `Instill Core` or `Instill Cloud`.

Expand Down
2 changes: 1 addition & 1 deletion instill/configuration/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
CONFIG_DIR = Path(
os.getenv(
"INSTILL_SYSTEM_CONFIG_PATH",
Path.home() / ".config/instill/",
Path.home() / ".config/instill/sdk/python/",
)
)

Expand Down
4 changes: 2 additions & 2 deletions instill/utils/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ class Logger:

@staticmethod
def initialize(
runlog_path=f"{home_dir}/.config/instill/run.log",
errorlog_path=f"{home_dir}/.config/instill/error.log",
runlog_path=f"{home_dir}/.config/instill/sdk/python/run.log",
errorlog_path=f"{home_dir}/.config/instill/sdk/python/error.log",
):
os.makedirs(os.path.dirname(runlog_path), exist_ok=True)
os.makedirs(os.path.dirname(errorlog_path), exist_ok=True)
Expand Down