chore: Add actionlint #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneypacheco
force-pushed
the
add-actionlint
branch
from
16e0d2d to
ead93cf
Compare
courtneypacheco
commented
Mar 6, 2025
ktdreyer
reviewed
Mar 6, 2025
This linter should validate GitHub workflow files as well as in-house GH action files. Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
courtneypacheco
force-pushed
the
add-actionlint
branch
from
ead93cf to
6e4fca2
Compare
|
The PR looks good to me. |
ktdreyer
approved these changes
Mar 6, 2025
Contributor
|
I'll merge this with Kamesh's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #5
Checklist:
Description of this Change
We should add
actionlintto this repository so that all GitHub workflow and in-house action files get validated.Note: all of these "actionlint" files were copied directly from: https://github.com/instructlab/instructlab/blob/main/.github/workflows/
The main difference is that I removed the "install dependent PRs" portion of actionlint because it's not applicable to this use case.