This repository was archived by the owner on Sep 9, 2025. It is now read-only.
update read me with examples of trivial/non-trivial changes #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellb
previously requested changes
Jun 12, 2024
Member
russellb
left a comment
russellb
left a comment
There was a problem hiding this comment.
Thank you!
-
one spacing fix needed to make the linter happy. You should be able to just accept the suggested edit to fix it
-
one suggested addition to the list of non-trivial examples
nathan-weinberg
approved these changes
Jun 18, 2024
Member
nathan-weinberg
left a comment
nathan-weinberg
left a comment
There was a problem hiding this comment.
Pending @russellb's comments this LGTM! Thank you for taking this on @lhawthorn!
hickeyma
approved these changes
Jul 4, 2024
Member
hickeyma
left a comment
hickeyma
left a comment
There was a problem hiding this comment.
Thanks @lhawthorn for adding the clarification.
Member
Author
|
@Mergifyio rebase |
And clarify when action must be taken by an oversight committee member. This PR is meant to address issue 91. #91 Signed-off-by: Leslie Hawthorn <lhawthor@redhat.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Co-authored-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
✅ Branch has been successfully rebased |
lhawthorn
force-pushed
the
lhawthorn-patch-3
branch
from
71f8b89 to
4fd0bb4
Compare
russellb
approved these changes
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And clarify when action must be taken by an oversight committee member. This PR is meant to address #91
Closes #91