Updating to > 1.0 openai #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcp
force-pushed
the
main
branch
7 times, most recently
from
d45fc4d to
8598da5
Compare
danmcp
commented
Jun 26, 2024
| agg_score: float = 0.0 | ||
| model_args = f"pretrained= {self.model_path}, dtype= {self.model_dtype}" | ||
|
|
||
| model_args = f"pretrained={self.model_path},dtype={self.model_dtype}" |
Member
Author
There was a problem hiding this comment.
@alimaredia @alinaryan @JamesKunstle FYI in case you hit this issue as well.
danmcp
requested review from
JamesKunstle,
alimaredia,
alinaryan and
nathan-weinberg
nathan-weinberg
approved these changes
Jun 26, 2024
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
| FastChat | ||
| GitPython>=3.1.42,<4.0.0 | ||
| shortuuid | ||
| openai<1.0.0 |
Contributor
There was a problem hiding this comment.
are there any implications to this bump? or is it a clean reversioning?
Member
Author
There was a problem hiding this comment.
I might not be understanding the questions. But there were several changes with the API that needed corresponding changes on our side that are in the commit.
JamesKunstle
approved these changes
Jun 26, 2024
Contributor
JamesKunstle
left a comment
JamesKunstle
left a comment
There was a problem hiding this comment.
everything changes here looks good if it works during manual testing. one question about versioning implications but not something that should block merging.
alinaryan
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to a newer openai to not conflict with the cli