Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/instructlab/training/main_ds.py
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ def run_training(torch_args: TorchrunArgs, train_args: TrainingArgs) -> None:
DataProcessArgs(
# XXX(osilkin): make a decision here, either:
# 1. the CLI is fully responsible for managing where the data is written
# 2. we never cache it and simply write it to a tmp file everytime.
# 2. we never cache it and simply write it to a tmp file every time.
#
# An important reason for why #1 would be preferable is in the case of OpenShift/SELinux
# where the user has a defined place for new temporary data to be written.
Expand Down
2 changes: 1 addition & 1 deletion src/instructlab/training/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ def save_hf_format_ds(
log_rank_0(f"saving took {time.time() - start} seconds")


# this is native deepspeed saving with optimizer, schediuler
# this is native deepspeed saving with optimizer, scheduler
def save_model_ds_native(
args,
model,
Expand Down