fix: improve linting and automation#172
Merged
mergify[bot] merged 2 commits intoinstructlab:mainfrom Oct 1, 2024
Merged
Conversation
Member
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
mergify
bot
added
CI/CD
Member
nathan-weinberg
left a comment
nathan-weinberg
left a comment
There was a problem hiding this comment.
Generally LGTM, not sure why a new lint error is getting picked up? Maybe needs a rebase?
Member
Author
|
@mergify rebase |
In the current version of the training repo, we have a few commands that help us lint and check to see if there are any issues with types or incorrect imports. However; there is no easy fix available when these issues are detected. This commit introduces a few new functionalities: 1. Makefile receives 5 new commands: - toml-lint, which lints the pyproject.toml file - toml-fmt, which automatically formats the pyproject.toml file - check-engine, which checks that the specified container engine ($CENGINE) is installed - tests, which runs tests against the source repo - fix, which fixes all fixable issues 2. The tox.ini file receives a few additions: a. The testenv environment is defined with some preset values. Other targets are able to pull from this b. tox -e fix is added - automatically fixes all fixable problems c. tox -e tomllint is added - fixes all issues in the pyproject.toml file d. a [py] environment is added to specify the base python version Aside from this, the resulting pyproject.toml file is added after formatting is applied. Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
Contributor
✅ Branch has been successfully rebased |
RobotSail
force-pushed
the
improve-ci
branch
from
08a69ec to
3cc768c
Compare
Member
Author
|
@nathan-weinberg Tests are passing now |
nathan-weinberg
approved these changes
Sep 27, 2024
JamesKunstle
approved these changes
Oct 1, 2024
Contributor
JamesKunstle
left a comment
JamesKunstle
left a comment
There was a problem hiding this comment.
looks like a good addition to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version of the training repo, we have a few commands that help us lint
and check to see if there are any issues with types or incorrect imports. However;
there is no easy fix available when these issues are detected.
This commit introduces a few new functionalities:
a. The testenv environment is defined with some preset values. Other targets are able to pull from this
b. tox -e fix is added - automatically fixes all fixable problems
c. tox -e tomllint is added - fixes all issues in the pyproject.toml file
d. a [py] environment is added to specify the base python version
Aside from this, the resulting pyproject.toml file is added after formatting is applied.
Signed-off-by: Oleg S 97077423+RobotSail@users.noreply.github.com