Skip to content

feat: add total_samples as a field to logs being emitted #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesKunstle merged 1 commit into from
Nov 11, 2024
Merged

feat: add total_samples as a field to logs being emitted #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/instructlab/training/main_ds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

# pylint: disable=no-name-in-module
from instructlab.dolomite.hf_models import GPTDolomiteForCausalLM
from torch.utils.data import DataLoader
from tqdm import tqdm
from transformers import AutoModelForCausalLM, get_scheduler
import torch
Expand Down Expand Up @@ -325,7 +326,7 @@ def train(
lr_scheduler,
accelerator: Accelerator,
tokenizer,
train_loader,
train_loader: DataLoader,
grad_accum,
metric_logger,
):
Expand Down Expand Up @@ -457,6 +458,7 @@ def train(
"total_loss": float(log_loss / num_loss_counted_tokens),
"samples_seen": samples_seen,
"gradnorm": global_grad_norm,
"total_samples": len(train_loader.dataset),
# "weight_norm": weight_norm,
}
)
Expand Down Expand Up @@ -620,6 +622,7 @@ def main(args):
"num_batches": len(train_loader),
"avg_samples_per_batch": len(dataset) / len(train_loader),
"samples_per_gpu": args.samples_per_gpu,
"total_samples": len(dataset), # emit the total number of samples
}
)

Expand Down