Skip to content

Change podman vllm filter to the ilab image #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Change podman vllm filter to the ilab image #713

merged 1 commit into from
Apr 7, 2025

Conversation

@nerdalert
Copy link
Member

@nerdalert nerdalert commented Apr 7, 2025 •
edited
Loading

  • The vllm-status api call was filtering on the old openai/vllm image that has been migrated to the ilab image. Resolves any issues with curl -X GET http://localhost:8080/vllm-containers showing null when there are vllm instances.

@nerdalert
Change podman vllm filter to the ilab image
2f008d6 
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
vishnoianil
vishnoianil approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit ee893b7 into instructlab:main Apr 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vishnoianil vishnoianil vishnoianil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nerdalert @vishnoianil