Skip to content
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Fix eslint warning#350

Merged
mscherer merged 3 commits intoinstructlab:mainfrom
mscherer:fix_eslint_warning
Feb 11, 2025
Merged

Fix eslint warning#350
mscherer merged 3 commits intoinstructlab:mainfrom
mscherer:fix_eslint_warning

Conversation

@mscherer
Copy link
Contributor

This should preventively fix error on #348.

eslint complain about that in a newer version
with @typescript-eslint/no-empty-object-type rule

Signed-off-by: Michael Scherer <misc@redhat.com>
@mscherer mscherer force-pushed the fix_eslint_warning branch 3 times, most recently from 2c5daf9 to 947a08f Compare February 11, 2025 09:17
eslint complain about @typescript-eslint/no-unused-expressions, and I
guess that's due to some settings around implicit return being set to
false somewhere.

Signed-off-by: Michael Scherer <misc@redhat.com>
@mscherer mscherer merged commit 895a820 into instructlab:main Feb 11, 2025
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant