[Student][MBL-11324] Submission Details Skeleton View #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKern
suggested changes
Apr 4, 2019
...t/src/androidTest/java/com/instructure/student/ui/renderTests/SubmissionDetailsRenderTest.kt
Outdated
Show resolved
Hide resolved
...t/src/androidTest/java/com/instructure/student/ui/renderTests/SubmissionDetailsRenderTest.kt
Show resolved
Hide resolved
...om/instructure/student/mobius/assignmentDetails/submissionDetails/SubmissionDetailsUpdate.kt
Outdated
Show resolved
Hide resolved
...m/instructure/student/mobius/assignmentDetails/submissionDetails/ui/SubmissionDetailsView.kt
Show resolved
Hide resolved
...m/instructure/student/mobius/assignmentDetails/submissionDetails/ui/SubmissionDetailsView.kt
Outdated
Show resolved
Hide resolved
apps/student/src/main/res/layout/fragment_submissiont_details.xml
Outdated
Show resolved
Hide resolved
CalvinKern
reviewed
Apr 4, 2019
...instructure/student/mobius/assignmentDetails/submissionDetails/SubmissionDetailsPresenter.kt
Outdated
Show resolved
Hide resolved
|
|
CalvinKern
reviewed
Apr 4, 2019
| private val fragmentManager: FragmentManager | ||
| ) : MobiusView<SubmissionDetailsViewState, SubmissionDetailsEvent>( | ||
| R.layout.fragment_submissiont_details, | ||
| R.layout.fragment_submission_details, |
CalvinKern
approved these changes
Apr 4, 2019
This was referenced Oct 21, 2025
[MBL-19424][Teacher] Extend submission filtering with differentiation tags and custom statuses
#3310
Merged
6 tasks
kristofnemere
added a commit
that referenced
this pull request
Nov 24, 2025
Fixed issue #1: Empty state only appeared after manual refresh when all ToDo items were marked as done via checkboxes. Changes: - Added applyFiltersLocally() call in startCheckboxDebounceTimer() after items are added to removingItemIds for animation - This ensures itemsByDate is updated to reflect filtered completed items - Empty state now appears automatically when last item is completed Test plan: - Mark all visible ToDo items as done using checkboxes - Verify empty state appears automatically after animation (~1 second) - Test with various filter combinations (Show Completed on/off) - Verify both swipe-to-done and checkbox trigger empty state correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.