Cloud build metrics docs #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehoag
approved these changes
Apr 15, 2019
Contributor
joehoag
left a comment
joehoag
left a comment
There was a problem hiding this comment.
Looks OK to me. (Though I am generally unfamiliar with this logic.)
Might we want to move the cloud_build_metrics folder to some more centralized location, like the mobile_shared repo?
Contributor
Author
I have thought about that. I'd want to discuss with the team first. This code doesn't really have an owner right now so I'm worried about moving it off repo. |
kristofnemere
added a commit
that referenced
this pull request
Nov 24, 2025
Fixed issue #11: Account-level calendar events were clickable when they shouldn't be. Changes: - Added isClickable field to ToDoItemUiState (defaults to true) - In ToDoListViewModel.mapToUiState(), detect account-level events by checking if contextType equals "Account" (case-insensitive) - Set isClickable to false for account-level calendar events - In ToDoListScreen.ToDoItemContent(), conditionally apply clickable modifier based on isClickable flag using Modifier.then() Account-level calendar events now appear in the ToDo list but are not clickable, preventing navigation to invalid URLs. Test plan: - Create account-level calendar events - Verify they appear in ToDo list - Verify clicking on them does nothing (no navigation) - Verify other items (course/user events, assignments, etc.) remain clickable - Verify checkbox and swipe-to-done still work on account events 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.