Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud build metrics docs #11

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@bootstraponline
Copy link
Member

bootstraponline commented Apr 12, 2019

No description provided.

@joehoag
Copy link
Contributor

joehoag left a comment

Looks OK to me. (Though I am generally unfamiliar with this logic.)

Might we want to move the cloud_build_metrics folder to some more centralized location, like the mobile_shared repo?

@bootstraponline

This comment has been minimized.

Copy link
Member Author

bootstraponline commented Apr 15, 2019

Might we want to move the cloud_build_metrics folder to some more centralized location, like the mobile_shared repo?

I have thought about that. I'd want to discuss with the team first. This code doesn't really have an owner right now so I'm worried about moving it off repo. espresso in mobile-shared is actually used by all the Android apps.

bootstraponline added some commits Apr 15, 2019

@bootstraponline bootstraponline merged commit a003c1f into master Apr 15, 2019

5 checks passed

ci/bitrise/3875692b192c4eb3/pr Passed - Android Open Source Parent
Details
ci/bitrise/43a4503585e48423/pr Passed - Android Open Source Student
Details
ci/bitrise/758ed6bba9746be5/pr Passed - Android Open Source Teacher
Details
ci/bitrise/d7d5e0d1dc2f33b8/pr Passed - Cloud Build Metrics
Details
license/cla Contributor License Agreement is signed.
Details

@bootstraponline bootstraponline deleted the docs branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.