Skip to content

Commit e88ca27

Browse files
committed
feat(ui-elements,ui-themes): add link decoration brand variable to canvas theme
This variable should be set to 'underline' in canvas if the "underline all links" feature is enabled. TEST PLAN: Verify that there is no change to the Link component examples Change-Id: I14ad18c33007c0e1b2f049a9f18debb665f8dcd6 Reviewed-on: https://gerrit.instructure.com/158531 Reviewed-by: Ryan Shaw <ryan@instructure.com> Product-Review: Jennifer Stern <jstern@instructure.com> Tested-by: Jenkins QA-Review: Dan Sasaki <dsasaki@instructure.com>
1 parent d49430f commit e88ca27

File tree

2 files changed

+2
-0
lines changed
  • packages

2 files changed

+2
-0
lines changed

packages/ui-elements/src/components/Link/theme.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ generator['canvas-a11y'] = generator['canvas-high-contrast'] = function ({ color
5858
generator['canvas'] = function (variables) {
5959
return {
6060
color: variables['ic-link-color'],
61+
textDecoration: variables['ic-link-decoration'],
6162
hoverColor: darken(variables['ic-link-color'], 10)
6263
}
6364
}

packages/ui-themes/src/canvas/base/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ export const brandVariables = {
5858
'ic-brand-font-color-dark': colors.textDarkest,
5959

6060
'ic-link-color': colors.textBrand,
61+
'ic-link-decoration': 'none',
6162

6263
'ic-brand-button--primary-bgd': colors.backgroundBrand,
6364
'ic-brand-button--primary-text': colors.textLightest,

0 commit comments

Comments
 (0)