Skip to content

Density gain option #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

Density gain option #652

merged 2 commits into from
Oct 4, 2023

Conversation

chris-langfield
Copy link
Contributor

@chris-langfield chris-langfield commented Sep 26, 2023 •
edited
Loading

Adds gain option to the Density plot

@chris-langfield chris-langfield added the enhancement New feature or request label Sep 26, 2023
mayofaulkner
mayofaulkner reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mayofaulkner mayofaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. So if both gain and vmax and vmin are given then gain will take precedence? Is this the behavior you want?

@chris-langfield
Copy link
Contributor Author

Yeah exactly. I figured the method level argument should override the ones passed to imshow

@chris-langfield chris-langfield merged commit 935c0c7 into develop Oct 4, 2023
@chris-langfield chris-langfield deleted the density_gain_option branch October 4, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayofaulkner mayofaulkner mayofaulkner left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-langfield @mayofaulkner