Remove default ports + Add RedirectPath#117
Closed
amineck wants to merge 5 commits intoint128:masterfrom
Closed
Conversation
amineck
changed the title
slimaneakalie
approved these changes
Jan 2, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 ! Thanks for the awesome package.
This PR addresses 2 small concerns we've been facing with the library.
1- The library keeps the PORT when redirecting even if it's the default port (ex: https://127.0.0.1:443 instead of https://127.0.0.1), which require us (for some destinations) to create an extra oauth app when testing with the CLI
2- Add support for a RedirectPath