Skip to content

Update setup.py to expose only snappy and _snappy as top-level mo…#53

Merged
martindurant merged 1 commit intointake:masterfrom
kronosapiens:master
Aug 23, 2017
Merged

Update setup.py to expose only snappy and _snappy as top-level mo…#53
martindurant merged 1 commit intointake:masterfrom
kronosapiens:master

Conversation

@kronosapiens
Copy link
Copy Markdown
Contributor

When trying to add this package as a dependency, our build tool began giving strange errors: it thought that this package would meet all requirements.

This was because the earlier setup.py had packages = ['.'], implying that this package provided everything. This PR updates setup.py to explicitly expose only snappy as a package provided by this library.

@martindurant
Copy link
Copy Markdown
Member

Thank you, sounds very reasonable. package_dir probably isn't even required (although I don't think it can hurt).

@martindurant martindurant merged commit 6963505 into intake:master Aug 23, 2017
@kronosapiens
Copy link
Copy Markdown
Contributor Author

I added package_dir to avoid having to move the source code into a snappy package directory (setup.py was failing initially because it was looking for an inner snappy package). package_dir tells distutils that the snappy directory is really just root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants