fix imports for python 3#56
Merged
martindurant merged 3 commits intointake:masterfrom Oct 2, 2017
Merged
Conversation
Member
|
Does this now need a |
Contributor
Author
|
Not in 2.7 (I tested). I think this syntax was introduced in 2.5, IIRC. Edit: tested 2.6 and it works, too. |
Member
|
All looks ok to me - anyone else with comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54 apparently wasn't tested on python 3; it tries to do some relative import stuff, which doesn't work. This fixes it.
I also noticed that
setup.pyusesinstall_requiresbut doesn't actually usesetuptools.setup, so that line only does anything if you're installing withpipand not if you're usingsetup.pydirectly. I changed it to usesetuptoolsif available.