Skip to content

Fixed monaco suggestions#1007

Merged
SukuWc merged 8 commits intostablefrom
bug/Suggestions
Mar 18, 2025
Merged

Fixed monaco suggestions#1007
SukuWc merged 8 commits intostablefrom
bug/Suggestions

Conversation

@elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Mar 5, 2025

Bugfix. Bug description can be found in original ticket.

Key fatures fixed:

  • Monaco should display correct adressing of element specific function suggestions (e.g.: self:potmeter_value on elements, and element[0]:potmeter_value)
  • Monaco should display each suggestion once

Closes #934

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

Visit the preview URL for this PR (updated for commit 21d88d5):

https://grid-editor-web--pr1007-bug-suggestions-psw3cmpy.web.app

(expires Thu, 20 Mar 2025 16:33:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet moved this to Ready for QA in Editor Roadmap Mar 5, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Mar 6, 2025
@Greg-Orca
Copy link
Contributor

Test failed

After element[x] , the suggestion still includes self:, but it's a syntax error. It should suggest without self: in this case
Screenshot 2025-03-06 at 14 52 10

@Greg-Orca Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Mar 6, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 6, 2025
@elsoazemelet
Copy link
Contributor Author

Test failed

After element[x] , the suggestion still includes self:, but it's a syntax error. It should suggest without self: in this case Screenshot 2025-03-06 at 14 52 10

Out of scope of this ticket, possibly intended working? Needs discussin with @SukuWc

@Greg-Orca
Copy link
Contributor

Discussed with @SukuWc. It should be displayed without self:

@Greg-Orca Greg-Orca moved this from Ready for QA to In Progress in Editor Roadmap Mar 6, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 8, 2025
@Greg-Orca
Copy link
Contributor

Greg-Orca commented Mar 12, 2025

Syntax highlighting is different. The functions were yellow before, but now only the global functions are yellow.

Screenshot 2025-03-12 at 13 03 59

@Greg-Orca Greg-Orca moved this from Ready for QA to Sprint Backlog (Active) in Editor Roadmap Mar 12, 2025
@Greg-Orca Greg-Orca moved this from Sprint Backlog (Active) to In Progress in Editor Roadmap Mar 12, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 12, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Mar 13, 2025
@Greg-Orca Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Mar 13, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 13, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Mar 13, 2025
@Greg-Orca
Copy link
Contributor

functions are not highlighted in yellow color

@Greg-Orca Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Mar 13, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 13, 2025
@Greg-Orca
Copy link
Contributor

Test Passed

@Greg-Orca Greg-Orca moved this from Ready for QA to Done in Editor Roadmap Mar 17, 2025
@SukuWc SukuWc merged commit c750a91 into stable Mar 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Monaco suggestions duplications should be fixed

3 participants