Skip to content

Reworked and fixed Lookup block#1052

Merged
elsoazemelet merged 3 commits intostablefrom
bug/Lookup
Apr 7, 2025
Merged

Reworked and fixed Lookup block#1052
elsoazemelet merged 3 commits intostablefrom
bug/Lookup

Conversation

@elsoazemelet
Copy link
Contributor

Closes #1010

Reworked lookup block to accomodate input fields and buttons from UI-kit.
All working is expected to be the same as before the change.

New expected working is similiar to variable type blocks:

  • All entered values must be syntax correct
  • Input fields with commas (and other invalid values) are considered syntax errors
  • Lookup block is reverted to last syntax correct state after the block is out of scope

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

Visit the preview URL for this PR (updated for commit 3eaeeff):

https://grid-editor-web--pr1052-bug-lookup-mgk3t4hl.web.app

(expires Tue, 01 Apr 2025 12:01:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet moved this to Ready for QA in Editor Roadmap Mar 20, 2025
@elsoazemelet elsoazemelet moved this from Ready for QA to In Progress in Editor Roadmap Mar 24, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Mar 24, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Mar 25, 2025
@Greg-Orca
Copy link
Contributor

Test Passed

Lookup block working, and field checks works correctly

@Greg-Orca Greg-Orca moved this from QA in progress to Done in Editor Roadmap Mar 25, 2025
@elsoazemelet elsoazemelet merged commit 237215f into stable Apr 7, 2025
12 checks passed
@Greg-Orca Greg-Orca mentioned this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: Comma in Lookup 'Output' Variable Field Creates a New Input Pair Field

2 participants