Skip to content

Fixed element name calculation#1313

Merged
SukuWc merged 6 commits intostablefrom
bug/ElementName
Sep 26, 2025
Merged

Fixed element name calculation#1313
SukuWc merged 6 commits intostablefrom
bug/ElementName

Conversation

@elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented Sep 16, 2025

Closes #1220

See original ticket for bug description!

@elsoazemelet elsoazemelet self-assigned this Sep 16, 2025
@elsoazemelet elsoazemelet moved this to Ready for QA in Editor Roadmap Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8f1600b):

https://grid-editor-web-backup--pr1313-bug-elementname-3n6nv7ek.web.app

(expires Sat, 25 Oct 2025 13:58:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 00eea830da0f03fae568536c6321e097e744b62a

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8f1600b):

https://grid-playwright-report-backup--pr1313-bug-elementname-i2br5uma.web.app

(expires Sun, 28 Sep 2025 14:06:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f8b487ac2a9cd0d351141c88302fe4e298ea57ef

@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Sep 25, 2025
@Greg-Orca
Copy link
Contributor

Greg-Orca commented Sep 25, 2025 •
edited
Loading

Bug: After clearing the whole module, the element name is still displaying

Screenshot 2025-09-25 at 11 40 22

@Greg-Orca Greg-Orca moved this from QA in progress to In Progress in Editor Roadmap Sep 25, 2025
@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Sep 25, 2025

ScreenRec_250925_18375.mp4

Reprod. on web preview and local branch, element name is cleared on module clear when element name is stored and when it is in memory only. Also tested with virtual modules.

Needs further repro steps!

@elsoazemelet elsoazemelet added question Further information is requested no-repro labels Sep 25, 2025
@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Sep 25, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Sep 25, 2025
@elsoazemelet elsoazemelet moved this from QA in progress to In Progress in Editor Roadmap Sep 25, 2025
@elsoazemelet elsoazemelet removed their assignment Sep 25, 2025
@elsoazemelet elsoazemelet removed question Further information is requested no-repro labels Sep 25, 2025
@elsoazemelet elsoazemelet self-assigned this Sep 25, 2025
@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Sep 25, 2025

Repro steps: Rename 3 elements

@elsoazemelet elsoazemelet moved this from In Progress to Ready for QA in Editor Roadmap Sep 25, 2025
@Greg-Orca Greg-Orca moved this from Ready for QA to QA in progress in Editor Roadmap Sep 25, 2025
@Greg-Orca
Copy link
Contributor

Greg-Orca commented Sep 25, 2025

passed

@Greg-Orca Greg-Orca moved this from QA in progress to Done in Editor Roadmap Sep 25, 2025
@SukuWc SukuWc merged commit 4bd8593 into stable Sep 26, 2025
14 checks passed
@SukuWc SukuWc mentioned this pull request Oct 14, 2025
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@elsoazemelet elsoazemelet

Labels

None yet

Projects

Editor Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Element name is only updatede on overlay if another element is selected

3 participants

@elsoazemelet @Greg-Orca @SukuWc