feat(mdc) : Add MDC Application Dash#836
feat(mdc) : Add MDC Application Dash#836camilamacedo86 wants to merge 1 commit intointegr8ly:add-mobile-servicesfrom camilamacedo86:AEROGEAR-9650
Conversation
camilamacedo86
requested review from
JameelB,
StevenTobin,
aidenkeating,
david-martin,
davidffrench,
davidkirwan,
dimitraz,
jessesarn,
maleck13,
matskiv,
mikenairn,
obrienrobert,
odra,
pawelpaszki,
pb82,
philbrookes,
pmccarthy,
sedroche,
tremes and
trepel
as code owners
camilamacedo86
requested review from
wei-lee
and removed request for
JameelB,
StevenTobin,
jessesarn,
obrienrobert,
pawelpaszki and
sedroche
|
@camilamacedo86 I am not sure why it is show up but this PR is already landed in the feature branch. See https://github.com/integr8ly/installation/blob/add-mobile-services/roles/mdc/defaults/main.yml |
|
This PR is in the feature branch anyway, so I am going to close this. |
|
Hi @wei-lee but if it was fully there, so why it shows the differences between both? |
|
@camilamacedo86 I believe that might be because your branch is stale (it's based on an old master, rather than the add-mobile-services branch). If you check out your branch locally and try to rebase it on top of the origin/add-mobile-services branch, you'll notice that you just get fast-forwarded to the tip of the origin/add-mobile-services branch, and no new commit is added on top, because the changes already exist on that branch. I guess GitHub just doesn't display the diff very well when the commits are this far apart or something. I'm not sure though. |
3 participants
Additional Information
https://issues.jboss.org/browse/AEROGEAR-9650
What
Re-applying changes since it was missed in some rebase with the master in this branch.