Fix various name resolution errors around routine references #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
force-pushed
the
routine_references_are_annoying
branch
from
638bb33 to
056c55b
Compare
fourls
requested changes
May 8, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
I'm a little confused about how this code will resolve declarations where the type is inferred rather than notated.
delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolutionHelper.java
Show resolved
Hide resolved
.../src/test/resources/au/com/integradev/delphi/symbol/RoutineReferenceAssignedToProcedural.pas
Show resolved
Hide resolved
fourls
requested changes
May 8, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good, I just think we should add a comment to this code - since there's a little bit of context that's unclear from just reading.
cirras
force-pushed
the
routine_references_are_annoying
branch
from
056c55b to
ac32d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves name resolution on routine references in:
var/constdeclarationsvardeclarationsconstdeclarationsMultidimensional constant arrays are especially improved, as their subarrays couldn't ever resolve properly before.