Plan output keeps changing randomly

[brikis98]

Terraform Version

Terraform v0.10.7

Affected Resource(s)

• github_team_repository

Terraform Configuration Files

The basic structure is a module that defines a team and the repos that team can access:

resource "github_team" "team" {
  name = "${var.team_name}"
}

resource "github_team_repository" "repos" {
  count      = "${length(var.team_repo_names)}"
  team_id    = "${github_team.team.id}"
  repository = "${element(var.team_repo_names, count.index)}"
  permission = "pull"
}

We use this module to manage ~40 teams, each with access to 10 - 50 repos.

Expected Behavior

Since all of the code has already been applied, I expect to see "no changes" when I run terraform plan.

Actual Behavior

Every time I run terraform plan, I get a completely different output. Sometimes it says it wants to create team foo and give it access to a bunch of repos, sometimes team bar, sometimes several teams, sometimes "no changes", etc.

Steps to Reproduce

1. terraform apply
2. terraform plan

Important Factoids

My best guess is that Terraform is making one API call for every (team, repo) pair, this results in way too many API calls, getting throttled, and Terraform is hiding the error message.

References

• Perhaps Github Provider: Support API Rate Limiting #5?

[damacus]

If you're getting throttled. You should see a 500 error from the github api.

You can mitigate against this behaviour by turning down the parallelism e.g. -parallelism=5.

I suspect there isn't much we can do about the API calls, as we're tied to how it's implemented in https://github.com/google/go-github/

It does sound like something hasn't been applied, or something is reverting an earlier apply.

[brikis98]

You should see a 500 error from the github api.

Terraform doesn't show any errors. Where would this show up?

I suspect there isn't much we can do about the API calls, as we're tied to how it's implemented in

Terraform should show an error in these cases instead of swallowing the error and showing random diffs!

It does sound like something hasn't been applied, or something is reverting an earlier apply.

No, everything has been applied, there are no diffs at all. Besides, running plan shows different diffs every time.

[majormoses]

Hmm sounds like a different problem than what I am facing, Could you replicate this with a small number of repos, teams, etc? If so share the terraform declarations, plan outputs, state before and after, and any other debug information that you think is relevant.

You should see a 500 error from the github api.

Actually I believe they return a 429 rather than a 500, I can't recall exactly but I recall seeing messages around rate limiting in the terraform errors.

I suspect there isn't much we can do about the API calls, as we're tied to how it's implemented in

There is absolutely something we can do for it as they have support in their SDK as I discovered here: https://github.com/terraform-providers/terraform-provider-github/issues/5#issuecomment-333365306 I just am not very comfortable writing golang. If it was something more like ruby or python I would probably do this myself.

No, everything has been applied, there are no diffs at all. Besides, running plan shows different diffs every time.

I have seen constant changing plans but they were consistent in their behavior with the aws provider on a number of resources such as s3 buckets do to sorting json and I suspect there could be similar at play so we need as much information as possible.

[majormoses]

Just to confirm if you are being rate limited they use a 403 like this:

* module.devops_repo_<ORG>-<REPO>.github_branch_protection.master: github_branch_protection.master: GET https://api.github.com/repos/<ORG>/<REPO>/branches/master/protection: 403 API rate limit of 5000 still exceeded until 2018-06-22 13:19:46 -0700 PDT, not making remote request. [rate reset in 7m12s]

[github-actions]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[github-actions]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!