Skip to content

feat: read timeout for github_ip_ranges data source#1978

Closed
kimxogus wants to merge 1 commit into
integrations:mainfrom
kimxogus:feat/ip-ranges-timeout
Closed

feat: read timeout for github_ip_ranges data source#1978
kimxogus wants to merge 1 commit into
integrations:mainfrom
kimxogus:feat/ip-ranges-timeout

Conversation

@kimxogus
Copy link
Copy Markdown

Resolves #1961


Before the change?

  • Adds 5 minutes default timeout for github_ip_ranges data source.

After the change?

  • Terraform will stop reading github ip ranges after 5 minutes timeout

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kimxogus
Copy link
Copy Markdown
Author

Can we write tests for read timeout? I don't know how to write tests for timeouts.

@kfcampbell
Copy link
Copy Markdown
Contributor

In this case, I don't think writing an integration test to cover timeouts is a great idea because it'd slow down our CI runs too much. Instead, I think manually testing following our instructions here.

@github-actions
Copy link
Copy Markdown

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions Bot added the Status: Stale Used by stalebot to clean house label Jul 22, 2024
@github-actions github-actions Bot closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Stale Used by stalebot to clean house

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Configurable timeout for github_ip_ranges data source

2 participants