feat: read timeout for github_ip_ranges data source#1978
Closed
kimxogus wants to merge 1 commit into
Closed
Conversation
1 task
Author
|
Can we write tests for read timeout? I don't know how to write tests for timeouts. |
Contributor
|
In this case, I don't think writing an integration test to cover timeouts is a great idea because it'd slow down our CI runs too much. Instead, I think manually testing following our instructions here. |
|
👋 Hey Friends, this pull request has been automatically marked as |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1961
Before the change?
github_ip_rangesdata source.After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!