Skip to content

Conversation

@usmonster
Copy link
Contributor

@usmonster usmonster commented Mar 5, 2025

Resolves #2579


Before the change?

  • merge_queue ruleset docs missing link to rule schema.
  • merge_queue.max_entries_to_merge rule description is copy-pasted from merge_queue.max_entries_to_build.

After the change?

  • The link to the rule schema has been added.
  • merge_queue.max_entries_to_merge rule description is correct.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@usmonster
Copy link
Contributor Author

usmonster commented May 27, 2025

Hello! Can this please be reviewed (& hopefully merged) by a maintainer? Thanks! (cc: @kfcampbell @nickfloyd)

@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@deiga
Copy link
Contributor

deiga commented Dec 8, 2025

Hey @usmonster 👋

Thank you for your contribution! I'm in the process of overhauling our docs foundations in #2987

Would you be willing to rebase/recreate your changes against that branch?

@usmonster
Copy link
Contributor Author

Hi @diega, thanks for the heads-up. I could rebase, but since mine is a tiny change, would it be simpler for this to be merged down first? What do you think?

@deiga
Copy link
Contributor

deiga commented Dec 11, 2025

It's not going to be simpler, because I'm ENTIRELY overhauling the docs even removing the current files 😬

But, I'll take it. It's my "fault" for starting this work pre-emptively of the v7 release 😬

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell added this to the v6.9.1 Patch milestone Dec 11, 2025
@stevehipwell stevehipwell added the Type: Documentation Improvements or additions to documentation label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS]: Add missing link to schema for merge_queue repository rule

5 participants