[MAINT] Remove unnecessary separate API call for repo topics in github_repository#3086
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
@deiga have you seen the comment at the top of the edit repo REST API docs about updating topics? |
Yeah, I spotted it yesterday and re-drafted this. There is still useful cleanup here |
ac97cf8 to
c8e8f67
Compare
stevehipwell
left a comment
There was a problem hiding this comment.
This looks good in principal, just a few suggesitons/questions.
|
@stevehipwell Thanks for the review, I've addressed your comments |
3ee38f1 to
61d0170
Compare
|
@deiga could you please rebase this PR? |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
61d0170 to
fe1294f
Compare
Before the change?
topicsfor agithub_repositorywould always do a separate API call to update topics, even though the Repo API nowadays supports topics directlyAfter the change?
github_repositoryresourcesPull request checklist
Schema migrations have been created if needed (example)Docs have been reviewed and added / updated if needed (for bug fixes / features)Does this introduce a breaking change?
Please see our docs on breaking changes to help!