Skip to content

Conversation

@ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented May 7, 2024

PR Checklist

What requirement is this design document for?

#issue_number

Anything the reviewer should know when reviewing this PR?

This only works when using Docker to build and serve the docs.
Run make serve-docs and look at the benchmarking API page.

If there are any other design Pull Requests or requirements, please link them here (i.e. intel-retail/automated-self-checkout )

Related PR for API doc changes: intel-retail/performance-tools#46 (needs to be merged first)

Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
@ejlee3 ejlee3 added the documentation Improvements or additions to documentation label May 7, 2024
Dockerfile.docs Outdated
rm -rf /var/lib/apt/lists/*

WORKDIR /apis
RUN wget https://github.com/ejlee3/performance-tools/archive/refs/heads/add-sphinx.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put this on the normal git instead of yours?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - I need to merge the other PR first, then we can do this, but I left it this way for now so that people can try it out and make sure it works for them too.

Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Copy link

@jim-wang-yutsung jim-wang-yutsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejlee3 ejlee3 merged commit e1fad36 into intel-retail:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants