feat(i18n): Hebrew (he-IL) translation + RTL layout support#490
Open
cdtauman wants to merge 2 commits into
Open
feat(i18n): Hebrew (he-IL) translation + RTL layout support#490cdtauman wants to merge 2 commits into
cdtauman wants to merge 2 commits into
Conversation
…ize remaining UI strings - Add Hebrew (he-IL) dictionary with full parity to en-US (829/829 keys). - Register Hebrew in the language selector and drive document dir/lang via an isRTL watcher in the i18n store (rtl/ltr toggling on language change). - Externalize remaining hardcoded UI strings into en-US keys across App, Chat, PromptArea, settings, dialogs, history, and preset components. - Migrate directional Tailwind utilities to logical properties (ml/mr -> ms/me, left/right -> start/end, pl/pr -> ps/pe) so layouts mirror in RTL. - Add preset/variant/tag translation helpers in lib/utils.ts. - Let long translated labels wrap instead of truncating in workflow settings. Verified: vue-tsc, eslint, and prettier all pass. Signed-off-by: חיים דב טאומן <cdtauman@gmail.com>
Author
|
@qiacheng @mschuettlerTNG — would appreciate your review when you have a moment. A few notes that may help:
Happy to split into a smaller RTL-infrastructure-only PR (store watcher + logical CSS migration, ~20 files) if that's easier to review first, with the Hebrew dictionary as a follow-up.
|
Signed-off-by: חיים דב טאומן <cdtauman@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description:
Adds a full Hebrew (he-IL) translation, end-to-end Right-to-Left (RTL) layout support, and externalizes the remaining hardcoded UI strings into the
en-USdictionary so the whole app can be localized. Rebased cleanly on the latestmain.Related Issue:
None.
Changes Made:
he-IL.jsonwith 100% key parity toen-US.json(829/829 keys, 0 missing / 0 extra). Hebrew added to the language selector.isRTLcomputed in the i18n store + a watcher that togglesdocument.documentElement.dir(rtl/ltr) andlangon language change.ml/mr → ms/me,left/right → start/end,pl/pr → ps/pe) across components so layouts mirror correctly in RTL.languages.*keys across App, Chat, PromptArea, settings, dialogs, history and preset components; added the matchingen-USkeys as a foundation for future languages.lib/utils.ts.Testing Done:
vue-tsc --noEmit(type-check): passes, 0 errors.eslint .(lint:ci): passes, 0 errors.prettier --check .(format:ci): passes.Screenshots:
N/A (text/layout changes) — can add on request.
Checklist: