Skip to content

Remove ALLOCATOR_DESC::IsUMA. #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove ALLOCATOR_DESC::IsUMA. #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ allocatorDesc.Device = Device;
allocatorDesc.Adapter = Adapter;

// Use CheckFeatureSupport
allocatorDesc.IsUMA = true;
allocatorDesc.ResourceHeapTier = D3D12_RESOURCE_HEAP_TIER_1;

ComPtr<gpgmm::d3d12::ResidencyManager> residency; // Optional
Expand Down
8 changes: 0 additions & 8 deletions src/fuzzers/D3D12ResourceAllocatorFuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,11 @@ extern "C" int LLVMFuzzerInitialize(int* argc, char*** argv) {
allocatorDesc.Adapter = dxgiAdapter;

// Populate the options.
D3D12_FEATURE_DATA_ARCHITECTURE arch = {};
if (FAILED(d3dDevice->CheckFeatureSupport(D3D12_FEATURE_ARCHITECTURE, &arch, sizeof(arch)))) {
return 0;
}

allocatorDesc.IsUMA = arch.UMA;

D3D12_FEATURE_DATA_D3D12_OPTIONS options = {};
if (FAILED(d3dDevice->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS, &options,
sizeof(options)))) {
return 0;
}

allocatorDesc.ResourceHeapTier = options.ResourceHeapTier;

if (FAILED(
Expand Down
8 changes: 0 additions & 8 deletions src/gpgmm/d3d12/ResourceAllocatorD3D12.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,6 @@ namespace gpgmm::d3d12 {
*/
EVENT_RECORD_OPTIONS RecordOptions;

/** \brief Specifies if unified memory architecture (UMA) support is enabled.

Used to determine if resource heaps can exist in shared memory.

Required parameter. Use CheckFeatureSupport to determine if supported.
*/
bool IsUMA;

/** \brief Specifies the adapter's tier of resource heap support.

Used to determine if resource categories (texture and buffers) can co-exist in the
Expand Down
1 change: 0 additions & 1 deletion src/samples/D3D12Sample.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ HRESULT Init() {
gpgmm::d3d12::ALLOCATOR_DESC desc = {};
desc.Adapter = adapter3;
desc.Device = device;
desc.IsUMA = arch.UMA;
desc.ResourceHeapTier = options.ResourceHeapTier;

Microsoft::WRL::ComPtr<gpgmm::d3d12::ResourceAllocator> resourceAllocator;
Expand Down
1 change: 0 additions & 1 deletion src/tests/D3D12Test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ namespace gpgmm::d3d12 {
// Required parameters.
desc.Adapter = mAdapter;
desc.Device = mDevice;
desc.IsUMA = mIsUMA;
desc.ResourceHeapTier = mResourceHeapTier;

// Pre-fetching is enabled by default. However for testing purposes, pre-fetching changes
Expand Down