Add option to disable custom heaps. #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds allocator flag to disable using custom-equivalent heaps internally. This is a workaround for DirectML failing to treat the custom-equivalent of D3D12_HEAP_TYPE_DEFAULT as the same type.
bbernhar
added a commit
that referenced
this pull request
Sep 7, 2022
Failing WebNN CI due to D3D12_MEMORY_POOL_UNKNOWN being required. This reverts commit 5f06e51.
bbernhar
added a commit
that referenced
this pull request
Sep 7, 2022
bbernhar
added a commit
that referenced
this pull request
Sep 7, 2022
bbernhar
added a commit
that referenced
this pull request
Sep 7, 2022
bbernhar
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds allocator flag to disable using custom-equivalent heaps internally. This is a workaround for DirectML failing to treat the custom-equivalent of D3D12_HEAP_TYPE_DEFAULT as the same type.