Skip to content

Fix EnqueueMakeResident from never being enabled. #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix EnqueueMakeResident from never being enabled. #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/gpgmm/d3d12/ResidencyManagerD3D12.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,10 @@ namespace gpgmm::d3d12 {
// asynchronous MakeResident, called EnqueueMakeResident, instead first. Should
// EnqueueMakeResident fail, fall-back to using synchronous MakeResident since we may be
// able to continue after calling Evict again.
if (mDevice3 != nullptr) {
ComPtr<ID3D12Device3> device3;
if (SUCCEEDED(mDevice->QueryInterface(IID_PPV_ARGS(&device3)))) {
ReturnIfFailed(EnsureResidencyFenceExists());
ReturnIfSucceeded(mDevice3->EnqueueMakeResident(
ReturnIfSucceeded(device3->EnqueueMakeResident(
D3D12_RESIDENCY_FLAG_NONE, numberOfObjectsToMakeResident, allocations,
mResidencyFence->GetFence(), mResidencyFence->GetLastSignaledFence() + 1));
}
Expand Down
1 change: 0 additions & 1 deletion src/gpgmm/d3d12/ResidencyManagerD3D12.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ namespace gpgmm::d3d12 {
HRESULT EnsureResidencyFenceExists();

ID3D12Device* mDevice = nullptr;
ID3D12Device3* mDevice3 = nullptr;
IDXGIAdapter3* mAdapter = nullptr;

const float mMaxPctOfVideoMemoryToBudget;
Expand Down