Skip to content

Warn when over budget. #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Warn when over budget. #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/gpgmm/d3d12/ResidencyManagerD3D12.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ namespace gpgmm::d3d12 {
static constexpr uint64_t kDefaultEvictSizeInBytes = GPGMM_MB_TO_BYTES(50);
static constexpr float kDefaultMaxPctOfVideoMemoryToBudget = 0.95f; // 95%
static constexpr float kDefaultMinPctOfBudgetToReserve = 0.50f; // 50%
static constexpr float kMinCurrentUsageOfBudgetReportingThreshold = 0.90f;

// Creates a long-lived task to recieve and process OS budget change events.
class BudgetUpdateTask : public VoidCallback {
Expand Down Expand Up @@ -525,9 +526,35 @@ namespace gpgmm::d3d12 {
pVideoMemoryInfo->CurrentUsage > pVideoMemoryInfo->Budget) {
WarnEvent(this, MessageId::kBudgetExceeded)
<< GetMemorySegmentName(memorySegmentGroup, mIsUMA)
<< " GPU memory exceeds budget: "
<< " GPU memory usage exceeds budget: "
<< GPGMM_BYTES_TO_MB(pVideoMemoryInfo->CurrentUsage) << " vs "
<< GPGMM_BYTES_TO_MB(pVideoMemoryInfo->Budget) << " MBs.";
} else {
const float currentUsageOfBudget =
SafeDivide(pVideoMemoryInfo->CurrentUsage, pVideoMemoryInfo->Budget);
if (pVideoMemoryInfo->Budget > 0 &&
currentUsageOfBudget > kMinCurrentUsageOfBudgetReportingThreshold) {
EventMessage message = WarnEvent(this, MessageId::kBudgetExceeded);
message << GetMemorySegmentName(memorySegmentGroup, mIsUMA)
<< " GPU memory usage is above budget threshold: "
<< currentUsageOfBudget * 100 << "% vs "
<< kMinCurrentUsageOfBudgetReportingThreshold * 100 << "%";

// Check if even evicting resident heaps would get us back below the budget or not.
// Otherwise, warn the developer that E_OUTOFMEMORY is likely unavoidable.
if (pVideoMemoryInfo->CurrentUsage > mStats.CurrentMemoryUsage &&
(pVideoMemoryInfo->CurrentUsage - mStats.CurrentMemoryUsage >
pVideoMemoryInfo->Budget)) {
message
<< "There is not enough memory to page-out to get below the budget. This "
"likely means there are more external than internal heaps that cannot "
"be "
"evicted because they are unmanaged by GPGMM. Consider using CreateHeap "
"to import them: "
<< GPGMM_BYTES_TO_MB(pVideoMemoryInfo->CurrentUsage) << " vs "
<< GPGMM_BYTES_TO_MB(mStats.CurrentMemoryUsage) << " MBs.";
}
}
}

// Not all segments could be used.
Expand Down